Stretch to Buster Upgrade

Notes so far:

• Upgrade needsrestart first and set NEEDRESTART_SUSPEND=1 to avoid be prompted to restart services (they will all be restarted on reboot)
• dpkg: error processing archive /var/cache/apt/archives/needrestart_3.4-5_all.deb (--unpack): unable to create '/etc/apt/disabled.apt.conf.d/99needrestart.dpkg-new' (while processing './etc/apt/apt.conf.d/99needrestart'): No such file or directory. I think I got this message because I set the environment variable NEEDRESTART_SUSPEND=1 before upgrading needrestart. I fixed with:

  mkdir -p /etc/apt/disabled.apt.conf.d/
  

I should have fixed with unsetting the env variable and installing needrestart again

• php curl packages seem to be removed on upgrade (7.0, 7.1 and 7.2), we want to keep them. Why did they get removed?
• doveconf: Warning: Obsolete setting in /etc/dovecot/conf.d/99-mfpl.conf:27: ssl_protocols has been replaced by ssl_min_protocol (fixed via puppet)
• doveconf: Fatal: Error in configuration file /etc/dovecot/conf.d/10-ssl.conf line 13: ssl_key: Can't open file /etc/dovecot/private/dovecot.key: No such file or directory (see ​debian bug) - fix with ln -s /etc/dovecot/private/dovecot.pem /etc/dovecot/private/dovecot.key
• Errors were encountered while processing: postfwd but when I reran apt install postfwd it went through without error

Prompted config files

• /etc/logrotate.d/apache2: Do we still need our customizations of this file?
• /etc/systemd/journald.conf: The new default file has some changes to commented out things... we should update ours to reflect the changes
• /etc/systemd/timesyncd.conf: The new default file has some changes to commented out things... we should update ours to reflect the changes
• /etc/cronttab: THe new default has helpful comments... we should update ours to reflect the changes
• /etc/logrotate.conf: new defaults keep less logs around, we should update ours to reflect
• /etc/ssh/sshd_config: I think we have already incorporated these changes
• /etc/default/postfwd
• /etc/default/spamassassin