Opened 6 years ago

Closed 5 years ago

#7300 closed Task/To do item (fixed)

roundcube just released 0.9.2 -- we should upgrade

Reported by: https://id.mayfirst.org/dkg Owned by: https://id.mayfirst.org/dkg
Priority: High Component: Tech
Keywords: roundcube roundcube.dev.mayfirst.org roundcube.mayfirst.org Cc:
Sensitive: no

Description

roundcube just released 0.9.1. We should upgrade https://roundcube.dev.mayfirst.org/ to it, and verify that it works as expected; if that's OK, then we should upgrade https://roundcube.mayfirst.org/ to match.

Attachments (1)

devroundcubepdfnotice.png (69.7 KB) - added by https://id.mayfirst.org/mahood 6 years ago.
Iceweasel PDF notification on logging into roundcube dev site

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 years ago by https://id.mayfirst.org/dskallman

  • Owner set to https://id.mayfirst.org/dkg
  • Status changed from new to assigned

dkg are you responsible for this? If not, who is so I can assign to the right person?

comment:2 Changed 6 years ago by https://id.mayfirst.org/dkg

0.9.1 is now live on https://roundcube.dev.mayfirst.org/ tagged as roundcube-0.9.1-mfpl1 (also as roundcube-0.9.1+mfpl, before i changed my mind about how to best represent the tag in question). In order to make sure that tag was visible on stallman, i also had to move the mfpl-0.9 branch label to the same commit as the new tag.

It seems to work for me. i would appreciate any feedback from people who commonly use roundcube mail who might be willing to try out https://roundcube.dev.mayfirst.org and report if there are any major gotchas.

Changed 6 years ago by https://id.mayfirst.org/mahood

Iceweasel PDF notification on logging into roundcube dev site

comment:3 Changed 6 years ago by https://id.mayfirst.org/mahood

This image Iceweasel PDF notification on logging into roundcube dev site is what i see when logging into the https://roundcube.dev.mayfirst.org/ site using Iceweasel 22.0a2. The page as you maybe able to tell loads fine. In https://roundcube.mayfirst.org/ this does not happen.

~mv

Last edited 6 years ago by https://id.mayfirst.org/mahood (previous) (diff)

comment:4 Changed 6 years ago by https://id.mayfirst.org/srevilak

I tried https://roundcube.dev.mayfirst.org, and saw something similar to what mv experienced.

  • Firefox (20.0) displays a bar at the top with the text "Additional plugins are required to display all the media on this page". (However, I can't figure out which plugins firefox requires.)

Via Tamper Data, I see two requests that might be problematic

13:30:09.217[349ms][total 349ms] Status: 200[OK]
GET https://roundcube.dev.mayfirst.org/program/resources/blank.pdf Load Flags[VALIDATE_ALWAYS ] Content Size[921] Mime Type[application/pdf]
   Request Headers:
      Host[roundcube.dev.mayfirst.org]
      User-Agent[Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0]
      Accept[text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8]
      Accept-Language[en-US,en;q=0.5]
      Accept-Encoding[gzip, deflate]
      DNT[1]
      Referer[https://roundcube.dev.mayfirst.org/?_task=mail]
      Cookie[roundcube_sessid=redacted; roundcube_sessauth=redacted; mailviewsplitterv=226]
      Connection[keep-alive]
      Cache-Control[max-age=0]
   Response Headers:
      Date[Mon, 20 May 2013 17:30:09 GMT]
      Server[Apache/2.2.16 (Debian)]
      Last-Modified[Mon, 20 May 2013 16:57:29 GMT]
      Etag["399-4dd293a56b040"]
      Accept-Ranges[bytes]
      Content-Length[921]
      Keep-Alive[timeout=15, max=90]
      Connection[Keep-Alive]
      Content-Type[application/pdf]

==================================================================


13:30:09.218[418ms][total 418ms] Status: 200[OK]
GET https://roundcube.dev.mayfirst.org/program/resources/blank.tif Load Flags[VALIDATE_ALWAYS ] Content Size[270] Mime Type[image/tiff]
   Request Headers:
      Host[roundcube.dev.mayfirst.org]
      User-Agent[Mozilla/5.0 (X11; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0]
      Accept[image/png,image/*;q=0.8,*/*;q=0.5]
      Accept-Language[en-US,en;q=0.5]
      Accept-Encoding[gzip, deflate]
      DNT[1]
      Referer[https://roundcube.dev.mayfirst.org/?_task=mail]
      Cookie[roundcube_sessid=redacted; roundcube_sessauth=redacted; mailviewsplitterv=226]
      Connection[keep-alive]
      Cache-Control[max-age=0]
   Response Headers:
      Date[Mon, 20 May 2013 17:30:09 GMT]
      Server[Apache/2.2.16 (Debian)]
      Last-Modified[Fri, 19 Apr 2013 01:09:12 GMT]
      Etag["10e-4daac5deebe00"]
      Accept-Ranges[bytes]
      Content-Length[270]
      Keep-Alive[timeout=15, max=89]
      Connection[Keep-Alive]
      Content-Type[image/tiff]

One requests "blank.pdf", and the other requests "blank.tif".

comment:5 Changed 6 years ago by https://id.mayfirst.org/dkg

I'm using iceweasel 21 (between the versions used by srevilak and mahood), and i don't see the misbehavior in question. i'm inspecting the network requests with iceweasel's built in network console:

  • right click the page
  • choose "inspect element"
  • in the inspector pane which opens at the bottom of the page, click "web console"
  • make sure the "Net" console is enabled, and the other consoles (CSS, JS, Logging) are not.
  • refresh the page

the list of network requests i see is:

[13:53:50.411] GET https://roundcube.dev.mayfirst.org/ [HTTP/1.1 200 OK 344ms]
[13:53:50.875] GET https://roundcube.dev.mayfirst.org/skins/larry/styles.css?s=1366333752 [HTTP/1.1 200 OK 251ms]
[13:53:50.876] GET https://roundcube.dev.mayfirst.org/skins/larry/mail.css?s=1366333752 [HTTP/1.1 200 OK 342ms]
[13:53:50.877] GET https://roundcube.dev.mayfirst.org/plugins/jqueryui/themes/larry/jquery-ui-1.9.1.custom.css?s=1366333752 [HTTP/1.1 200 OK 568ms]
[13:53:50.878] GET https://roundcube.dev.mayfirst.org/skins/larry/ui.js?s=1369069049 [HTTP/1.1 200 OK 407ms]
[13:53:50.878] GET https://roundcube.dev.mayfirst.org/program/js/jquery.min.js?s=1366333752 [HTTP/1.1 200 OK 753ms]
[13:53:50.879] GET https://roundcube.dev.mayfirst.org/program/js/common.js?s=1366333752 [HTTP/1.1 200 OK 354ms]
[13:53:50.880] GET https://roundcube.dev.mayfirst.org/program/js/app.js?s=1369069049 [HTTP/1.1 200 OK 1197ms]
[13:53:50.880] GET https://roundcube.dev.mayfirst.org/program/js/list.js?s=1369069049 [HTTP/1.1 200 OK 636ms]
[13:53:50.881] GET https://roundcube.dev.mayfirst.org/plugins/jqueryui/js/jquery-ui-1.9.1.custom.min.js?s=1366333752 [HTTP/1.1 200 OK 1237ms]
[13:53:52.414] GET https://roundcube.dev.mayfirst.org/skins/larry/images/roundcube_logo.png [HTTP/1.1 200 OK 165ms]
[13:53:52.435] GET https://roundcube.dev.mayfirst.org/skins/larry/images/linen.jpg [HTTP/1.1 200 OK 530ms]
[13:53:52.436] GET https://roundcube.dev.mayfirst.org/skins/larry/images/linen_header.jpg [HTTP/1.1 200 OK 172ms]
[13:53:52.436] GET https://roundcube.dev.mayfirst.org/skins/larry/images/buttons.png [HTTP/1.1 200 OK 513ms]
[13:53:52.437] GET https://roundcube.dev.mayfirst.org/skins/larry/images/listicons.png [HTTP/1.1 200 OK 619ms]
[13:53:52.438] GET https://roundcube.dev.mayfirst.org/skins/larry/images/quota.png [HTTP/1.1 200 OK 577ms]
[13:53:52.438] GET https://roundcube.dev.mayfirst.org/skins/larry/images/selector.png [HTTP/1.1 200 OK 62ms]
[13:53:52.439] GET https://roundcube.dev.mayfirst.org/skins/larry/images/splitter.png [HTTP/1.1 200 OK 787ms]
[13:53:52.440] GET https://roundcube.dev.mayfirst.org/skins/larry/images/ajaxloader.gif [HTTP/1.1 200 OK 70ms]
[13:53:52.441] GET https://roundcube.dev.mayfirst.org/?_task=mail&_refresh=1&_mbox=INBOX&_action=list&_remote=1&_unlock=loading1369072432278&_=1369072432283 [HTTP/1.1 200 OK 564ms]
[13:53:52.442] GET https://roundcube.dev.mayfirst.org/?_task=mail&_action=getunread&_remote=1&_unlock=0&_=1369072432285 [HTTP/1.1 200 OK 302ms]

steve or mv, can either of y'all replicate this with your logins?

comment:6 Changed 6 years ago by https://id.mayfirst.org/dkg

part of 0.9.1 was this fix to firefox PDF support detection. Maybe it's relevant?

I've also followed up to a message on the upstream mailing list which mentions the problem as an aside; hopefully we can get a bit more clarity here.

comment:7 Changed 5 years ago by https://id.mayfirst.org/dkg

  • Summary changed from roundcube just released 0.9.1 -- we should upgrade to roundcube just released 0.9.2 -- we should upgrade

Looks like 0.9.2 is out now. we never completed the upgrade to 0.9.1 because of the warnings reported by steve and mv. This is disappointing, but we should keep pushing.

comment:8 Changed 5 years ago by https://id.mayfirst.org/dkg

I've upgraded https://roundcube.dev.mayfirst.org/ to 0.9.2, based on the roundcube-0.9.2-mfpl1 tag. steve and mv, can you test it to verify whether you get those error messages again?

comment:9 Changed 5 years ago by https://id.mayfirst.org/srevilak

I tested a few use cases on https://roundcube.dev.mayfirst.org.

With the last upgrade, mv and I noticed browser warnings about missing plugins. At the time, we believed this came from img references to .tif and .pdf files.

So far, no mention about missing plugins.

I've tried sending and reading messages, using a signature, and attaching files. So far, everything has worked as expected.

comment:10 Changed 5 years ago by https://id.mayfirst.org/dkg

mv says that he also doesn't see the problems any more. I'm going to go ahead and upgrade the live installation.

comment:11 Changed 5 years ago by https://id.mayfirst.org/dkg

  • Resolution set to fixed
  • Status changed from assigned to closed

OK, this is now done.

Please login to add comments to this ticket.

Note: See TracTickets for help on using tickets.